Skip to content

style: avoid using star imports #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2025
Merged

style: avoid using star imports #438

merged 2 commits into from
Jul 23, 2025

Conversation

nielspardon
Copy link
Member

This makes it easier to understand which types/constants/methods are actually used in the code.

@bestbeforetoday
Copy link
Contributor

The latest version of the Spotless plugin has a removeWildcardImports() step. Probably this change should include adoption of that Spotless capability; otherwise later changes will just end up regressing these changes and/or adding more wildcard imports.

@nielspardon
Copy link
Member Author

The latest version of the Spotless plugin has a removeWildcardImports() step. Probably this change should include adoption of that Spotless capability; otherwise later changes will just end up regressing these changes and/or adding more wildcard imports.

Good catch. I wasn't aware they had this now in Spotless.

@nielspardon
Copy link
Member Author

I rebased on latest main and pushed an additional commit upgrading spotless and enabling the removeWildcardImports option. The Spotless update did trigger some reformatting of existing code.

bestbeforetoday
bestbeforetoday approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@bestbeforetoday bestbeforetoday left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me.

It would be nice to figure out if we will proceed with #433 before merging this since it will introduce a fourth round of merge conflicts with that PR.

vbarua
vbarua approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated these in the past as I've seen them, so it's great that we can just enforce this via Spotless.

@vbarua vbarua merged commit d006fbc into substrait-io:main Jul 23, 2025
12 checks passed
@nielspardon nielspardon deleted the par-import-star branch August 5, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbarua vbarua vbarua approved these changes

@bestbeforetoday bestbeforetoday bestbeforetoday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nielspardon @bestbeforetoday @vbarua